0xDECAFBAD - Tag: programming

Beautiful Code

2007-10-10T03:59:02+00:00

Michael McCracken: "Once you get a piece of code to the point where you believe it works - it's passing its tests - go back over it and edit it. That is, go back and edit it for clarity, flow, and style. Just as if it were an essay."

This is something I just don't hear enough of - code as writing, code as communication. While I don't always make time to polish as much as I'd like, I'm always thinking about things like narrative and flow of a file of source code as well as the aesthetic shape and form of the code. Code is fiction, code is poetry.

Compilation free of syntax and parse errors is baseline competence - and sometimes just good luck. Apparent correct operation is not good enough: Moving on before the code has beauty is a poverty. Ugly code kills motivation and comprehension - which attracts bugs and induces a downward spiral in morale.

Unit tests clear the way for courage and bravery; beauty yields living code worth fighting for.

Smarty is on my evil list

2006-01-08T01:33:47+00:00

Although I have my grousing about PHP in general, I have to say that it makes much better template language as-is before pulling something like Smarty into the mix.

At this point, I consider Smarty to be evil—though I'm willing to admit that I haven't grokked it fully yet. And this is coming from a templating addict who has been at times in love with Template Toolkit in Perl, Velocity in Java, and Cheetah and Woven and ZPT/TAL in Python.

WordPress seems to have put native-PHP-as-templating to good use, so I've already got a favorite for comparison. But the use of Smarty in reBlog rubs me the wrong way. Of course, reBlog has a lot of highly-abstracted MVC architecture going on. And this, itself, is something I haven't much in my PHP explorations thus far. (In fact, I almost hate to see PHP chopped up in this J2EE-esque fashion, but that's another story. Oh, and reBlog rocks, by the way.)

But either way, Smarty makes this right-handed hacker feel like he's writing with his left. It seems to have a lot of weird conventions and terminology for which neither knowledge of PHP nor knowledge of other templating systems in general seem much help. It could just be a learning curve, but to me it seems like an odd sideways curve at the moment.

In fact, you know what? Smarty reminds me a lot of DTML in Zope. I hate DTML—it, also, is most firmly on my evil list.

Yuck. Again, it could be just that I haven't known Smarty long enough to like it... but yuck.

Archived Comments

Luka Kladaric
2006-01-08T11:55:40

I agree with you... I used Smarty in one project and am now using it in another work-in-progress... and I have to say, the decision to use it with the second was a bad one... Smarty is pretty cool for simple templating, but when you need raw power, it leaves you shipwrecked... I had to turn to some really black magic to get things done... Anyway, a rewrite of the first project is in negotiations and I'm 100% sure I will NOT be using Smarty there, either.
kellan
2006-01-08T14:34:57

Agreed. Using a templating languages with PHP makes no sense. (though I'm not sure the fact that WP does or doesn't do something makes it good design)
l.m.orchard
2006-01-08T15:03:33

Kellan: Oh, no, WordPress isn't an automatic gold standard for me... There's plenty that could be better about WP. (Not having checked out 2.0 yet) But, I just had a much better time setting up the templates for this blog than I have had in hacking around with templates implemented in Smarty.
Bob Aman
2006-01-08T17:41:17

Me, I just wish there was a templating system for Ruby for me to fall in love with. With all due respect to the Rails people, ERb just doesn't really do it for me.
Aristotle Pagaltzis
2006-01-08T21:04:14

Bob: port Kid to Ruby. :-)
Keith Gaughan
2006-01-08T21:28:05

What's moronic is that people go to all this trouble building templating systems when all you really need is extract(). Sad, really.
Bryce
2006-01-12T13:33:10

PHP as a template engine is more evil than Smarty. The main issue is that template authors may not be trustworthy. Once you include or eval() a PHP template the app is no longer in control and I don't see any way of structuring a PHP app such that it cannot be subverted from within.

The only defense seems to be using the tokenizer functions to build a PHP parser that validates templates against a "whitelist" of allowed operations. Savant's Restricted Compiler is about the only implementation out there, but it's not quite complete and seems to be more of a proof-of-concept than battle-tested code.

Whatever Smarty's faults, it solves the untrusted templates problem nicely.
l.m.orchard
2006-01-12T14:27:42

Bryce: Oh, I totally understand the implications of offering too much capability to template authors. That's just how much I dislike Smarty—I'm willing to risk it, rather than put up with that particular implementation. On the other hand, in my situation, I'm on the same team with the template developers, so we're all on the same team to sink or swim. I know it's not that simple, in principle, but it covers the 80% of the 80/20 equation.
Dougal Campbell
2006-01-12T15:25:25

Yeah, I was never able to get into Smarty either, and I've never been able to put my finger on why. Philosophically, I like the idea of using template engines, particularly if you're collaborating with a non-programming designer. I even wrote one (albeit a very simple one) myself, once. But I've never used any of the PHP template packages that I've looked at.
Bob Aman
2006-01-13T01:10:16

Aristotle: When TurboGears first came out, I almost did, believe it or not. But then I remembered that FeedTools eats all of the time I have available for open-source projects, and I figured someone else would probably do it for me anyways...
Aristotle Pagaltzis
2006-01-13T09:02:38

Hehe. Well, I plan to port it to Perl, in any case. :-)
Brian Grayless
2006-01-19T16:00:24

Smarty is really a waste of time. Some food for thought....

Smarty for Dummies?

Just write better code!!!
Tali Banana
2006-02-01T07:33:41
Well, quite opinionated I see.

Smarty solves some fantastic problems and the cacheing system is beyond fabulous at this level.

I've used Smarty on several projects and have been using it now exclusively for 4 years. Of course, I used others but it was getting sick coming to a new phase in a project and finding out the template system had become RIP....abandoned before their time.

Smarty has done two great things for me, and I'll speak about them until the day that PHP is abolished:
1. Smarty has reduced my code to a reasonably sized, scan-able, masterpiece. Having the logic and presentation seperate is so nice. I recently rewrote one of my old projects using smarty and all of a sudden it made sense! No more php in the html and no more html in the php. And that's something you can't solve without templates for you juniors out there.
2. Smarty's caching has turned monster db queries into non issues. Consider this. A top 10 list from all-time sales. I'm talking about searching a db with sales spanning 6 years for all items purchased and creating a top sales page. Easy! Smarty does it once and caches the results until I decide they need to be refreshed. Took a 4 second execution time down to less than 0.4 seconds. And all without having to implement a CMS or otherwise. Even if you have limitless resources to buy new hardware, caching like this still makes sense. And the intermediate php/html cache is brilliant. Everything is so much faster with smarty.
I can't deny, I love Smarty.
l.m.orchard
2006-02-01T11:43:36

Tali: I'm usually opinionated, but I try to listen & learn :)

The benefits you describe with Smarty would seem to come with any decent web development system. Separating logic and presentation are the general idea behind templating, and some sort of caching is a must no matter what you're using as a presentation-side tool. My beef is that, out of all the templating systems I've used, Smarty is one of the ugliest.
Tali Banana
2006-02-01T17:30:03

Smarty does need some standards redesign on the interface, as does php itself which has been well documented but slow going.

Coming from the PERL background and previous php template systems I've been very happy with Smarty in general, even if there are a few things that could be done to speed up the learning curve.

May be worthwhile jumping on the dev team and making some suggestions.
Aristotle Pagaltzis
2006-02-02T01:30:31

But why would you need a template system when you’re already working with PHP, which is itself a template system? Why do You don’t have to have different languages to be able to put the business logic in one file and the display logic in another.

Perl (not PERL), btw, has the Template Toolkit on the CPAN, which is the spiritual father of Smarty. (And it’s vaguely more defensible in Perl’s case becase Perl is not a template system; though constrated with Perl the deficiencies of TT’s mini language are just all the more painfully obvious.)

By all of which I mean to say that whether people use languages in stupid ways does not mean the language is the problem; not in either PHP’s or Perl’s case.

I also don’t see why you need a templating system to implement caching; in fact, having caching coupled with the template engine sounds like a bad distribution of responsibilities. (Indeed, Template Toolkit has no such facilities.) But there’s the Cache::Cache family of modules on the CPAN, which you can use to cache things completely independently of what is being cached – whether it be the output of a template, or the query results themselves, or anything else, which might not even have anything to do without any output you generate.
M.
2006-02-16T14:13:18

I've good experiences with the Expose PHP template engine (www.kwasd.nl/expose). It doesn't require you to learn a new language, because it uses plain PHP and still offers security, because it contains a tokenizer and, in fact, a small compiler. I used it for some projects and it really offered all I needed.

And for people who wonder why one would need a template engine: I work with designers and I don't want them to mingle application code. By setting up a shared folder which contains the templates, they can safely work on design and never need to touch my controller or module files. Especially since this template engine has a tokenizer/compiler, they can't call unsafe PHP functions (only those that you, the programmer, register).
Michal Migurski
2006-03-05T23:16:25

Smarty appealed to us because it offered a (relatively) clean way to separate the code from the HTML output. It's definitely got its problems. A large part of the choice was based on my perception of Smarty as having much thought & effort behind it, plus I like the idea of templates caching down to plain PHP. I've done a few PHP projects where I used PHP as the templating language, and frequently succumbed to the temptation to stash app logic into the templates where it didn't really belong. Smarty has a pretty extensive vocabulary, but has (so far) resisted the pull to incorporate more real-language features, like PHP did. It's worth remembering that PHP was originally supposed to be a template language for "real" code to be written in C. shudder

When we forked Reblog from Feed On Feeds, we were starting with raw-PHP display code mixed in with database calls, and it was a freaking disaster. One of my first design goals was to make it hacker-friendly, clarifying and documenting as many seams as possible so people could make localized changes more easily. I'd like to be using Python under the hood with Smarty on top, though there's a lot to be said for using commonly-known tools like Smarty in apps where you want to encourage modifications.

And Wordpress.... oh, Wordpress. My eyes roll back in my head when I'm forced to touch its convoluted innards. I pushed hard for a Reblog plug-in API specifically so I could cheerfully deprecate the old-style Wordpress plug-in. =)

Yahoo for stalking iPods in the hands of couriers

2005-11-03T18:29:12+00:00

If the new Yahoo! Maps were really cool, they'd've already done a mashup with DHL to let me obsessively stalk the courier in whose truck my returning iPod repair currently rests.

Come on, get with the program! When we've got GPS watches, "Status: With delivery courier / Location: (blank)" is no way to track a package! In the meantime, my repetitive information injury is flaring up as I refresh, refresh, refresh, refresh...

D.I.Y. checkout lane

2005-11-02T21:52:40+00:00

This might be a revealing admission: Listening to the TWiT podcast, and heard a bit where they were grousing about self-serve checkout lanes at stores. Leo Laporte went so far as to say he wants a human cashier who says hello, and a bagger at the end of the lane.

Personally? I like the self-serve checkout, even when they're a little buggy. If I end up having to hold something at a peculiar angle to scan it, I get over that quickly. In the end, I usually don't have to ask anyone for help, don't have to wait, and generally I get out of the store faster than anyone.

Maybe I'll grow out of it.

Archived Comments

Dougal Campbell
2005-11-02T21:13:46

I'd like it a lot more if they'd give you a discount to make up for the fact that they don't have to pay for a cashier and bagger.

I use the self-checkout when I only have a few items, and I think it will get me out of the store faster. But if I have a large number of items, or there's a regular checkout with no line, I'm generally happier letting somebody else do the scanning and bagging.
Jack Mottram
2005-11-02T23:33:51

Is this post from the future? I'd kill for self-service checkouts, but as far as I know they don't exist yet (in the UK). In fact, I can't quite work out how they'd work without folk 'forgetting' to scan half their shop and leaving with a bag full of stolen goods.
Pete Prodoehl
2005-11-03T01:29:29

Just once I'd like to use one of them without human intervention. The last time someone convinced me to try it, I think I needed a human to help out at least three times, not exactly a good user experience. I hate to say it, but I prefer having someone do it all for me. Unless of course there is a discount offered, then I would be willing to try it again. ;)
Eby
2005-11-03T02:45:40

I like the self checkout, usually fairly quick just because it is limited items. If they had more 12 item or less with a person I'd probably be just as happy but the lines get long there since there are only a couple.

Unfortunately they seem to be buggy and worn down here at least. I often go too quick for it and get the dreaded "take last item out of bag and scan it" then have to argue with the person over-seeing it that indeed it beeped and was scanned. I used to be a cashier though.

And there are of course those people that have all produce and are forced to look up the codes. Some stores I've been in are good enough to have stickers on the produce with the codes but that seems to be rarely the case these days.
Bill Seitz
2005-11-03T15:26:07

Yeah, I fear that these systems are unmaintainable because they try to do too much, specifically catch someone shoplifting. So you get those various alerts driven by unexpected weight changes in your bag, for reasons unknown. (I also recall some other problem always coming up during the payment process, but I can't remember what it was...)

Every place I've tried to use them, they are slower than normal cashiers because 1 human is left to cover 4-5 auto machines and you end up waiting for them to come fix things for you.